Add information regarding synchronous compilations in javacore#24236
Add information regarding synchronous compilations in javacore#24236dev-koan wants to merge 2 commits into
Conversation
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
3 times, most recently
from
fbec998 to
2d33ba0
Compare
mpirvu
left a comment
mpirvu
left a comment
There was a problem hiding this comment.
We have one decision to make: do we want to measure the times needed for synchronous compilations to be performed or the waiting time of application threads? there could be several application threads waiting for the same compilation to finish.
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
2 times, most recently
from
43f338e to
177844e
Compare
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
543fdd6 to
0825011
Compare
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
0825011 to
3ffce49
Compare
mpirvu
left a comment
mpirvu
left a comment
There was a problem hiding this comment.
LGTM. Please post an example of the output.
|
Also, please squash the 4 commits into 1. |
|
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
3ffce49 to
75bbae1
Compare
Ideally, i'd like to see each app thread maintain its own longest wait time (and associated info). For brevity, only threads that have wait times longer than a certain threshold (like 3ms or 10ms) should be reported it to javacore. |
|
If each thread maintains the name of the sync method, with long method names and many threads there could be some footprint increase. I like the idea of applying some filtering and not include quick compilations. |
|
@amicic To clarify: each app thread that is subject to a wait due to a synchronous compilation will have a dynamically allocated string in J9VMThread struct (to hold the name of the method it waited for). This string needs to be freed when the thread is destroyed. |
Added a struct in J9JITConfig to store information regarding synchronous compilations and print them in javacore file. Signed-off-by: Dev Agarwal <dev.agarwal@ibm.com>
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
75bbae1 to
286bba4
Compare
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
286bba4 to
ee2ee8c
Compare
…ilations, and also storing thread name
dev-koan
force-pushed
the
feature/SyncCompInfo
branch
from
ee2ee8c to
1ca1fb1
Compare
3 participants
Added a struct in J9JITConfig to store information regarding synchronous compilations and print them in javacore file.
Signed-off-by: Dev Agarwal dev.agarwal@ibm.com